HansBrende commented on a change in pull request #151: ANY23-445 Review
spotbugs issues
URL: https://github.com/apache/any23/pull/151#discussion_r336322455
##########
File path: api/src/main/java/org/apache/any23/extractor/ExtractorGroup.java
##########
@@ -78,6 +78,7 @@ public boolean allExtractorsSupportAllContentTypes() {
return true;
}
+ @SuppressWarnings("unlikely-arg-type")
Review comment:
Sorry, I wasn't clear. The code inside this method has a bug, as _correctly_
identified by the spotbugs plugin. The code is testing if a
`Collection<MIMEType>` contains a `String`. This will always return false, as a
`String` _cannot_ be an instance of `MIMEType`.
Therefore, the method needs to be fixed, and the spotbugs plugin is doing
its job correctly: no suppression of warnings is needed here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
