HansBrende commented on a change in pull request #151: ANY23-445 Review
spotbugs issues
URL: https://github.com/apache/any23/pull/151#discussion_r336325771
##########
File path: api/src/main/java/org/apache/any23/vocab/Vocabulary.java
##########
@@ -142,12 +142,12 @@ public IRI getProperty(String name, IRI defaultValue) {
*/
public IRI getPropertyCamelCase(String property) {
String[] names = property.split("\\W");
- String camelCase = names[0];
+ StringBuilder camelCase = new
StringBuilder(property.length()).append(names[0]);
for (int i = 1; i < names.length; i++) {
String tmp = names[i];
- camelCase += tmp.replaceFirst("(.)", tmp.substring(0,
1).toUpperCase(java.util.Locale.ROOT));
+ camelCase.append(tmp.replaceFirst("(.)", tmp.substring(0,
1).toUpperCase(java.util.Locale.ROOT)));
Review comment:
And now that I think about it more, I agree that there is definitely
something to be said for keeping the dependencies of the `api` module as few in
number as possible, so I think we should leave it as-is for now. Good call.
I'll mark this comment thread as 'resolved'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
