Github user vrozov commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/333#discussion_r69752755
--- Diff:
library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
@@ -80,29 +80,29 @@
{
@NotNull
private WindowDataManager windowDataManager;
- @NotNull
- protected final transient LinkedList<ScannedFileInfo>
currentWindowRecoveryState;
+
+ protected transient LinkedList<ScannedFileInfo>
currentWindowRecoveryState;
@Valid
@NotNull
private TimeBasedDirectoryScanner scanner;
- @NotNull
+
private Map<String, Map<String, Long>> referenceTimes;
private transient long sleepMillis;
public FileSplitterInput()
{
super();
- currentWindowRecoveryState = Lists.newLinkedList();
windowDataManager = new WindowDataManager.NoopWindowDataManager();
- referenceTimes = Maps.newHashMap();
scanner = new TimeBasedDirectoryScanner();
}
@Override
public void setup(Context.OperatorContext context)
{
+ currentWindowRecoveryState = Lists.newLinkedList();
+ referenceTimes = Maps.newHashMap();
--- End diff --
`referenceTimes` is not marked as transient, so it will be stored during
checkpointing and restored back from a checkpoint in case of failover. It is
necessary to check referenceTimes for `null`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
