Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/333#discussion_r69835747
--- Diff:
library/src/test/java/com/datatorrent/lib/io/fs/FileSplitterInputTest.java ---
@@ -499,7 +499,7 @@ public void testRecoveryOfBlockMetadataIterator()
throws InterruptedException
testMeta.fileSplitterInput.getScanner().setScanIntervalMillis(500);
- testMeta.fileSplitterInput.setup(testMeta.context);
--- End diff --
It's not a point. It's a question. I am asking if similar changes are
going to be made throughout the codebase?
To me this change is completely unnecessary. IMO code which was clean and
intuitive is made the opposite just because a handful of unused objects will be
present in stram.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
