Github user sanjaypujare commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/333#discussion_r69834329
--- Diff:
library/src/test/java/com/datatorrent/lib/io/fs/FileSplitterInputTest.java ---
@@ -499,7 +499,7 @@ public void testRecoveryOfBlockMetadataIterator()
throws InterruptedException
testMeta.fileSplitterInput.getScanner().setScanIntervalMillis(500);
- testMeta.fileSplitterInput.setup(testMeta.context);
--- End diff --
For the first point, we can (should) add another unit test just to test
FileSplitterInput.setup() which in any case sounds like a better idea.
The 2nd point is not very clear. Are you saying there are many other
instances of non-transient fields which should be checked for null in setup()
or are you saying there are many fields which should ideally be declared
transient?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
