Github user 243826 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/129#issuecomment-152325895
@ilganeli the coding guidelines are there to leave no room for different
interpretation of what commonly agreed best practice is. So before introducing
personal flavors, please get it approved in the same fashion as the coding
guidelines were approved.
```
jkl = xyz(a, b, c)
```
to
```
jkl =
x(a
b,
c);
```
is very subjective in terms of value add.
You said it correctly that you are looking at the code for the first time
so it's difficult. There is no expectation that people will get it right the
first time they read it. After your reformatting, I am looking at the changes
you made and now I find it difficult to comprehend what's going on :-)
Separately - please do not submit reformatting changes. There are tools
which can do it in one shot and probably save your and reviewers' time for
better utilization elsewhere. May be if you want to work on these tools, I can
share some code with you. Doing this piecemeal or without non format related
changes just mucks with the history and context crippling the tools which help
us utilize them. On top, it wrongly attributes it to a person who in some cases
may not even understand the code.
If you are fixing a bug - then of course go ahead and reformat the newly
written / modified code. Keeping the changes local will be nice as others
working on the code will know what exactly changed. This will also make sure
that we do not try to fix something that is not broken.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
