Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/129#issuecomment-152338508
@ilooner @243826 I think maintaining provenance of the code is definitely
important, how would you recommend submitting a patch that maintains this?
With regards to formatting, the formatting in this patch is consistent with
the style guide and check style as it stood when I submitted the patch. Since
both of those have undergone significant changes since that point, I've just
submitted an update which brings this code up to date.
@PramodSSImmaneni I agree that touching critical path code is risky, hence
my ask for a comprehensive review. If it proves too difficult to analyze this
patch, I could submit a series of smaller patches based on this work that does
this in a series of smaller steps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
