Github user ilooner commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/129#issuecomment-152336506
@243826 I think there is value in breaking up code into functions. At some
points the original deployInputStreams function is nested 5 levels deep. That
may be easy for you to read but for some people that is difficult to read.
Maybe we can share these changes with a wider audience on the dev mailing list
to get more opinions?
I also agree that it is important to preserve attribution. I know it is
possible to change the author of a commit, maybe @ilganeli can provide a dummy
commit which restores the original author of the code that has been moved to
separate functions.
If you still feel this is not the place to be making these changes could
you suggest a ticket for @ilganeli to work on, so that we can utilize his
contributions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
