Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/175#discussion_r46152198
--- Diff:
bufferserver/src/test/java/com/datatorrent/bufferserver/server/ServerTest.java
---
@@ -72,7 +72,8 @@ public static void setupServerAndClients() throws
Exception
instance = new Server(0, 4096,8);
address = instance.run(eventloopServer);
- assert (address instanceof InetSocketAddress);
+ assertTrue(address instanceof InetSocketAddress);
+ assertFalse(address.isUnresolved());
--- End diff --
I think assert for InetSocketAddress (address is declared as
InetSocketAddress) and dealing with unresolved address were parts of the
original code that was later refactored. Server.run() returns resolved
InetSocketAddress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
