Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/175#discussion_r46191846
--- Diff:
bufferserver/src/main/java/com/datatorrent/bufferserver/internal/DataList.java
---
@@ -139,13 +140,16 @@ public void rewind(final int baseSeconds, final int
windowId) throws IOException
}
/*
- TODO: properly rewind Data List iterators, especially handle case
when iterators point to blocks past the last block.
- */
+ * TODO: properly rewind Data List iterators, especially handle case
when iterators point to blocks past the last
+ * block.
+ */
final int numberOfInMemBlockPermits =
this.numberOfInMemBlockPermits.addAndGet(numberOfInMemBlockRewound);
- assert numberOfInMemBlockPermits < MAX_COUNT_OF_INMEM_BLOCKS : "Number
of in memory block permits " + numberOfInMemBlockPermits + " exceeded
configured maximum " + MAX_COUNT_OF_INMEM_BLOCKS + '.';
+ assert numberOfInMemBlockPermits < MAX_COUNT_OF_INMEM_BLOCKS : "Number
of in memory block permits " +
+ numberOfInMemBlockPermits + " exceeded configured maximum " +
MAX_COUNT_OF_INMEM_BLOCKS + '.';
resumeSuspendedClients(numberOfInMemBlockPermits);
- logger.debug("Discarded {} in memory blocks during rewind. Number of
in memory blocks permits {} after rewinding {}. ", numberOfInMemBlockRewound,
numberOfInMemBlockPermits, this);
+ logger.debug("Discarded {} in memory blocks during rewind. Number of
in memory blocks permits {} after" +
+ " rewinding {}.", numberOfInMemBlockRewound,
numberOfInMemBlockPermits, this);
--- End diff --
I agree with Thomas on this. I think in this case, we should break it after
the comma and not break the string literal, even if the string literal makes
the line over 120 chars.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
