Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/175#discussion_r46152484
--- Diff:
bufferserver/src/main/java/com/datatorrent/bufferserver/internal/DataList.java
---
@@ -177,11 +181,13 @@ public void reset()
public void purge(final int baseSeconds, final int windowId)
{
final long longWindowId = (long)baseSeconds << 32 | windowId;
- logger.debug("Purging {} from window ID {} to window ID {}", this,
Codec.getStringWindowId(first.starting_window),
Codec.getStringWindowId(longWindowId));
+ logger.debug("Purging {} from window ID {} to window ID {}", this,
Codec.getStringWindowId(first.starting_window),
+ Codec.getStringWindowId(longWindowId));
int numberOfInMemBlockPurged = 0;
synchronized (this) {
- for (Block prev = null, temp = first; temp != null &&
temp.starting_window <= longWindowId; prev = temp, temp = temp.next) {
+ for (Block prev = null, temp = first; temp != null &&
temp.starting_window <= longWindowId;
--- End diff --
It depends on the width of the monitor. When I don't use external monitor,
wrapping at 120 char length improves readability.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
