Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/208#discussion_r50175982
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StramLocalCluster.java 
---
    @@ -308,6 +313,24 @@ public StramLocalCluster(LogicalPlan dag) throws 
IOException, ClassNotFoundExcep
         this.dnmgr = new StreamingContainerManager(dag);
         this.umbilical = new UmbilicalProtocolLocalImpl();
     
    +    Method addURL;
    +    URLClassLoader loader;
    +    try {
    +      loader = (URLClassLoader)ClassLoader.getSystemClassLoader();
    +      addURL = URLClassLoader.class.getDeclaredMethod("addURL", new 
Class[] { URL.class });
    +      addURL.setAccessible(true);
    +    } catch (NoSuchMethodException e) {
    +      throw new RuntimeException("No method named addURL found.", e);
    +    }
    +
    +    for (String jarPath : dag.getJarResources().keySet()) {
    +      try {
    +        addToClasspath(jarPath, loader, addURL);
    +      } catch (InvocationTargetException | IllegalAccessException e) {
    --- End diff --
    
    `try catch` should be outside the `for` loop


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to