Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/208#discussion_r50292943
--- Diff:
engine/src/test/java/com/datatorrent/stram/StramMiniClusterTest.java ---
@@ -235,6 +251,20 @@ private LogicalPlan createDAG(LogicalPlanConfiguration
lpc) throws Exception
return dag;
}
+ private void addExtraTestJar(LogicalPlan dag)
+ {
+ try {
+ File tmp1 = File.createTempFile("tmp1", null);
+ File tmp2 = File.createTempFile("tmp2", null);
+ tmp1.deleteOnExit();
+ tmp2.deleteOnExit();
+ dag.addJarResource(tmp1.getAbsolutePath(), true);
+ dag.addJarResource(tmp2.getAbsolutePath(), false);
+ } catch (IOException e) {
+ LOG.error("Failed to create temporary file.", e);
--- End diff --
why not throw exception instead of just logging it? In fact why catch
Exception, let calling function handle it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
