Github user chinmaykolhatkar commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/208#discussion_r50367453
  
    --- Diff: 
engine/src/test/java/com/datatorrent/stram/StramMiniClusterTest.java ---
    @@ -227,6 +242,7 @@ public void testSetupShutdown() throws Exception
       private LogicalPlan createDAG(LogicalPlanConfiguration lpc) throws 
Exception
       {
         LogicalPlan dag = new LogicalPlan();
    +    addExtraTestJar(dag);
    --- End diff --
    
    There will be duplicate of code.. Because most of the things I want to do 
are part of testSetupShutdown test.
    But I get your point, I'll have a seperate test than the current one to 
test this functionality.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to