Hi,

+1 (binding)

This should probably be called RC2 (RC stands for release candidate). Putting 
it in the same spot as the previous one can be confusing.

I checked:
- incubating in name
- signatures and hashes fine
- DISCLAIMER exists
- LICENSE and NOTICE good
- no unexpected binary files in release
- all source file have ASF headers
- can compile but not sure if it's correct (on OSX)

I think the compile instructions can be improved as they are unclear. Some of 
the make commands fail to work e.g. "make check” and running the binary gives 
this error:
./apisix:77: module 'tinyyaml' not found: I assume this is just my environment.

Thanks,
Justin

Reply via email to