+1 ( binding )

I checked:
- incubating in name
- signatures and hashes fine
- DISCLAIMER exists
- LICENSE and NOTICE good
- no unexpected binary files in release
- all source file have ASF headers
- compiled and ran QuickStart on macOS

I checked:
- Download links are valid.
- Checksums and PGP signatures are valid.
- DISCLAIMER is included.
- LICENSE and NOTICE files are good.
- No binary file.
- All files have license headers if necessary.
- Quickstart in README.md

Below is a more detailed `limit-count` plugin test output:

multipass@impartial-moth:~/workspace/tmp/apache-apisix-0.9-rc1-incubating$
apisix version
0.9-rc1
multipass@impartial-moth:~/workspace/tmp/apache-apisix-0.9-rc1-incubating$
curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -X PUT -d '
> {
>     "uri": "/index.html",
>     "plugins": {
>         "limit-count": {
>             "count": 2,
>             "time_window": 60,
>             "rejected_code": 503,
>             "key": "remote_addr"
>         }
>     },
>     "upstream": {
>         "type": "roundrobin",
>         "nodes": {
>             "39.97.63.215:80": 1
>         }
>     }
> }'
HTTP/1.1 201 Created
Date: Tue, 19 Nov 2019 09:52:47 GMT
Content-Type: text/plain
Transfer-Encoding: chunked
Connection: keep-alive
Server: APISIX web server

{"node":{"value":{"plugins":{"limit-count":{"time_window":60,"count":2,"rejected_code":503,"key":"remote_addr","policy":"local"}},"uri":"\/index.html","upstream":{"nodes":{"
39.97.63.215:80
":1},"type":"roundrobin"}},"createdIndex":1262,"key":"\/apisix\/routes\/1","modifiedIndex":1262},"action":"set"}
multipass@impartial-moth:~/workspace/tmp/apache-apisix-0.9-rc1-incubating$
multipass@impartial-moth:~/workspace/tmp/apache-apisix-0.9-rc1-incubating$
curl -i http://127.0.0.1:9080/index.html
HTTP/1.1 404 Not Found
Content-Type: text/html
Content-Length: 150
Connection: keep-alive
X-RateLimit-Limit: 2
X-RateLimit-Remaining: 1
Date: Tue, 19 Nov 2019 09:53:28 GMT
Server: APISIX web server

<html>
<head><title>404 Not Found</title></head>
<body>
<center><h1>404 Not Found</h1></center>
<hr><center>openresty</center>
</body>
</html>
multipass@impartial-moth:~/workspace/tmp/apache-apisix-0.9-rc1-incubating$
curl -i http://127.0.0.1:9080/index.html
HTTP/1.1 404 Not Found
Content-Type: text/html
Content-Length: 150
Connection: keep-alive
X-RateLimit-Limit: 2
X-RateLimit-Remaining: 0
Date: Tue, 19 Nov 2019 09:53:29 GMT
Server: APISIX web server

<html>
<head><title>404 Not Found</title></head>
<body>
<center><h1>404 Not Found</h1></center>
<hr><center>openresty</center>
</body>
</html>
multipass@impartial-moth:~/workspace/tmp/apache-apisix-0.9-rc1-incubating$
curl -i http://127.0.0.1:9080/index.html
HTTP/1.1 503 Service Temporarily Unavailable
Date: Tue, 19 Nov 2019 09:53:30 GMT
Content-Type: text/html
Content-Length: 194
Connection: keep-alive
Server: APISIX web server

<html>
<head><title>503 Service Temporarily Unavailable</title></head>
<body>
<center><h1>503 Service Temporarily Unavailable</h1></center>
<hr><center>openresty</center>
</body>
</html>

On Tue, Nov 19, 2019 at 4:53 PM Lang Wang <totemofw...@apache.org> wrote:

> +1 (binding)
>
> I check those:
>
> [Y] Download links are valid.
> [Y] Checksums and PGP signatures are valid.
> [Y] DISCLAIMER is included.
> [Y] LICENSE and NOTICE files are good.
> [Y] No binary file.
> [Y] All files have license headers if necessary.
>
> It works fine on (docker) alpine 3.7, with:
> luarocks: 3.2.1
> etcd: 3.3.13
>
> ----
>
> And below is the debug log:
>
>
>
>
> *export RESTY_LUAROCKS_VERSION="3.2.1"export
> OPENRESTY_PREFIX='/usr/local/openresty'# luarocks*
> # install pre deps
> apk add --no-cache --virtual .build-deps \
> perl-dev \
> bash \
> build-base \
> curl \
> linux-headers \
> make \
> outils-md5 \
> perl \
> unzip \
> git
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> *cd /tmp \&& curl -fSL
>
> https://luarocks.github.io/luarocks/releases/luarocks-${RESTY_LUAROCKS_VERSION}.tar.gz
> <
> https://luarocks.github.io/luarocks/releases/luarocks-${RESTY_LUAROCKS_VERSION}.tar.gz
> >
> -o luarocks-${RESTY_LUAROCKS_VERSION}.tar.gz \&& tar xzf
> luarocks-${RESTY_LUAROCKS_VERSION}.tar.gz \&& cd
> luarocks-${RESTY_LUAROCKS_VERSION} \&& ./configure \
> --prefix=${OPENRESTY_PREFIX}/luajit \
> --with-lua=${OPENRESTY_PREFIX}/luajit \
> --with-lua-include=${OPENRESTY_PREFIX}/luajit/include/luajit-2.1 \&& make
> build \&& make install \&& cd - \&& rm -rf
> luarocks-${RESTY_LUAROCKS_VERSION}
> luarocks-${RESTY_LUAROCKS_VERSION}.tar.gz# proxy# export
> http_proxy=http://192.168.43.111:1087;export
> https_proxy=http://192.168.43.111:1087 <http://192.168.43.111:1087>;ln -sf
> /usr/local/openresty/luajit/bin/luarocks /usr/bin/luarocks \    && ln -sf
> /usr/local/openresty/luajit/bin/luarocks-admin /usr/bin/luarocks-admin \
> && ln -sf /usr/sbin/nginx /usr/bin/openrestybin='#!
> /usr/local/openresty/luajit/bin/luajit' \&& sed -i "1s@.*@$bin@"
> ./bin/apisix \&& apk del .build-deps 2>/dev/null# unset http_proxy# unset
> https_proxybash-4.4# make init./bin/apisix init./bin/apisix
> init_etcdbash-4.4# make runmkdir -p logsmkdir -p
> /tmp/apisix_cores//usr/bin/openresty -p $PWD/ -c $PWD/conf/nginx.conf#
> {bash-4.4# curl -i http://127.0.0.1:9080/apisix/admin/routes/1
> <http://127.0.0.1:9080/apisix/admin/routes/1> -X PUT -d '> {>     "uri":
> "/index.html",>     "plugins": {>         "limit-count": {>
> "count": 2,>             "time_window": 60,>             "rejected_code":
> 503,>             "key": "remote_addr">         }>     },>     "upstream":
> {>         "type": "roundrobin",>         "nodes": {>
> "192.168.29.198:80 <http://192.168.29.198:80>": 1>         }>     }>
> }'HTTP/1.1 201 CreatedDate: Tue, 19 Nov 2019 08:36:03 GMTContent-Type:
> text/plainTransfer-Encoding: chunkedConnection: keep-aliveServer: APISIX
> web
>
> server{"node":{"value":{"plugins":{"limit-count":{"time_window":60,"count":2,"rejected_code":503,"key":"remote_addr","policy":"local"}},"uri":"\/index.html","upstream":{"nodes":{"
> 192.168.29.198:80
> <http://192.168.29.198:80
> >":1},"type":"roundrobin"}},"createdIndex":15,"key":"\/apisix\/routes\/1","modifiedIndex":15},"action":"set"}bash-4.4#bash-4.4#bash-4.4#
> curl -I http://127.0.0.1:9080/index.html
> <http://127.0.0.1:9080/index.html>HTTP/1.1 200 OKContent-Type: text/html;
> charset=utf-8Content-Length: 0Connection: keep-aliveX-RateLimit-Limit:
> 2X-RateLimit-Remaining: 1Server: APISIX web serverDate: Tue, 19 Nov 2019
> 08:36:12 GMTCache-Control: no-store, no-cache, must-revalidate,
> post-check=0, pre-check=0Pragma: no-cacheExpires: Thu, 19 Nov 1981 08:52:00
> GMTSet-Cookie: PHPSESSID=98b4va2nmodnjb5u6dj8tkvj15; path=/bash-4.4# curl
> -I http://127.0.0.1:9080/index.html
> <http://127.0.0.1:9080/index.html>HTTP/1.1 200 OKContent-Type: text/html;
> charset=utf-8Content-Length: 0Connection: keep-aliveX-RateLimit-Limit:
> 2X-RateLimit-Remaining: 0Server: APISIX web serverDate: Tue, 19 Nov 2019
> 08:36:14 GMTCache-Control: no-store, no-cache, must-revalidate,
> post-check=0, pre-check=0Pragma: no-cacheExpires: Thu, 19 Nov 1981 08:52:00
> GMTSet-Cookie: PHPSESSID=d707hd1mph2il9eviq7s3l4460; path=/bash-4.4# curl
> -I http://127.0.0.1:9080/index.html
> <http://127.0.0.1:9080/index.html>HTTP/1.1 503 Service Temporarily
> UnavailableDate: Tue, 19 Nov 2019 08:36:58 GMTContent-Type:
> text/htmlContent-Length: 610Connection: keep-aliveServer: APISIX web
> server# }bash-4.4# make stop/usr/bin/openresty -p $PWD/ -c
> $PWD/conf/nginx.conf -s stop2019/11/19 08:21:15 [notice] 6261#6261: signal
> process startedbash-4.4# make reload/usr/bin/openresty -p $PWD/  -c
> $PWD/conf/nginx.conf -s reload2019/11/19 08:26:15 [notice] 6730#6730:
> signal process startedbash-4.4# make installinstall -d
> /usr/local/apisix/logs/install -d /usr/local/apisix/conf/certinstall
> conf/mime.types /usr/local/apisix/conf/mime.typesinstall conf/config.yaml
> /usr/local/apisix/conf/config.yamlinstall conf/cert/apisix.*
> /usr/local/apisix/conf/cert/install -d /usr/share/lua/5.1/apisix/luainstall
> lua/*.lua /usr/share/lua/5.1/apisix/lua/install -d
> /usr/share/lua/5.1/apisix/lua/apisixinstall lua/apisix/*.lua
> /usr/share/lua/5.1/apisix/lua/apisix/install -d
> /usr/share/lua/5.1/apisix/lua/apisix/admininstall lua/apisix/admin/*.lua
> /usr/share/lua/5.1/apisix/lua/apisix/admin/install -d
> /usr/share/lua/5.1/apisix/lua/apisix/coreinstall lua/apisix/core/*.lua
> /usr/share/lua/5.1/apisix/lua/apisix/core/install -d
> /usr/share/lua/5.1/apisix/lua/apisix/httpinstall lua/apisix/http/*.lua
> /usr/share/lua/5.1/apisix/lua/apisix/http/install -d
> /usr/share/lua/5.1/apisix/lua/apisix/http/routerinstall
> lua/apisix/http/router/*.lua
> /usr/share/lua/5.1/apisix/lua/apisix/http/router/install -d
> /usr/share/lua/5.1/apisix/lua/apisix/pluginsinstall
> lua/apisix/plugins/*.lua
> /usr/share/lua/5.1/apisix/lua/apisix/plugins/install -d
> /usr/share/lua/5.1/apisix/lua/apisix/plugins/grpc-transcodeinstall
> lua/apisix/plugins/grpc-transcode/*.lua
> /usr/share/lua/5.1/apisix/lua/apisix/plugins/grpc-transcode/install -d
> /usr/share/lua/5.1/apisix/lua/apisix/plugins/limit-countinstall
> lua/apisix/plugins/limit-count/*.lua
> /usr/share/lua/5.1/apisix/lua/apisix/plugins/limit-count/install -d
> /usr/share/lua/5.1/apisix/lua/apisix/plugins/prometheusinstall
> lua/apisix/plugins/prometheus/*.lua
> /usr/share/lua/5.1/apisix/lua/apisix/plugins/prometheus/install -d
> /usr/share/lua/5.1/apisix/lua/apisix/plugins/zipkininstall
> lua/apisix/plugins/zipkin/*.lua
> /usr/share/lua/5.1/apisix/lua/apisix/plugins/zipkin/install -d
> /usr/share/lua/5.1/apisix/lua/apisix/stream/pluginsinstall
> lua/apisix/stream/plugins/*.lua
> /usr/share/lua/5.1/apisix/lua/apisix/stream/plugins/install -d
> /usr/share/lua/5.1/apisix/lua/apisix/stream/routerinstall
> lua/apisix/stream/router/*.lua
> /usr/share/lua/5.1/apisix/lua/apisix/stream/router/install README.md
> /README.mdinstall bin/apisix /usr/bin/apisix# ELF checkbash-4.4# find . |
> xargs file | grep -i ELF./deps/lib/lua/5.1/librestychash.so:
>                                                                        ELF
> 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked,
> with debug_info, not stripped./deps/lib/lua/5.1/pb.so:
>
> ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked,
> with debug_info, not stripped./deps/lib/lua/5.1/librestyradixtree.so:
>
>  ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically
> linked, with debug_info, not stripped./deps/lib/lua/5.1/lfs.so:
>
>        ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically
> linked, with debug_info, not strippedbash-4.4# rm -rf
> depsbash-4.4#bash-4.4#bash-4.4# find . | xargs file | grep -i ELF*
>
>
>
> 吴钧泽 <wujunze1...@gmail.com> 于2019年11月19日周二 下午2:48写道:
>
> > +1 (binding)
> >
> > I checked:
> > - incubating in name
> > - signatures and hashes fine
> > - DISCLAIMER exists
> > - LICENSE and NOTICE good
> > - no unexpected binary files in release
> > - all source file have ASF headers
> > - can compile and can work on ubuntu18.04
> >
> > On MacOS10.15.1  AND  ubuntu 18.04, the APISIX works fine.
> >
> > Ming Wen <wenm...@apache.org> 于2019年11月16日周六 上午12:21写道:
> >
> > > Hello, Community,
> > > With the help and effort of our community, the previous issues were
> fixed
> > > already, we removed the dashboard submodule and removed logos in
> images.
> > > I am glad to invite everyone to move on to check and vote for our
> 0.9-RC1
> > > ROUND 2.
> > >
> > > Release notes:
> > >
> >
> https://github.com/apache/incubator-apisix/blob/v0.9/CHANGELOG.md#090-rc1
> > >
> > > The release candidates:
> > > https://dist.apache.org/repos/dist/dev/incubator/apisix/0.9-RC1/
> > >
> > > Git tag for the release:
> > > https://github.com/apache/incubator-apisix/tree/v0.9
> > >
> > > Release Commit ID:
> > >
> > >
> >
> https://github.com/apache/incubator-apisix/commit/31a545a72589f618db17bca794d4885914600361
> > >
> > > Keys to verify the Release Candidate:
> > > https://dist.apache.org/repos/dist/dev/incubator/apisix/KEYS
> > >
> > > Steps to validating the release:
> > > 1. Download the release
> > > ```
> > > wget
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/apisix/0.9-RC1/apache-apisix-0.9-rc1-incubating-src.tar.gz
> > > ```
> > >
> > > 2. Checksums and signatures
> > > ```
> > > wget https://dist.apache.org/repos/dist/dev/incubator/apisix/KEYS
> > > wget
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/apisix/0.9-RC1/apache-apisix-0.9-rc1-incubating-src.tar.gz.asc
> > > wget
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/apisix/0.9-RC1/apache-apisix-0.9-rc1-incubating-src.tar.gz.sha512
> > >
> > > shasum -c apache-apisix-0.9-rc1-incubating-src.tar.gz.sha512
> > >
> > > gpg --import KEYS
> > > # input `trust`, `5`, then `save`
> > > gpg --edit-key "wenming"
> > > gpg --verify apache-apisix-0.9-rc1-incubating-src.tar.gz.asc
> > > apache-apisix-0.9-rc1-incubating-src.tar.gz
> > > ```
> > >
> > > 3. Unzip and Check files
> > > ```
> > > tar zxvf apache-apisix-0.9-rc1-incubating-src.tar.gz
> > > ```
> > >
> > > 4. Build Apache APISIX:
> > > The runtime environment for Apache APISIX requires OpenResty and etcd,
> > > So please install dependencies first:
> > >
> > >
> >
> https://github.com/apache/incubator-apisix/blob/v0.9/doc/install-dependencies.md
> > >
> > > Then you can build from source release candidate:
> > >
> > >
> >
> https://github.com/apache/incubator-apisix/blob/v0.9/doc/how-to-build.md#installation-via-source-release-candidate
> > >
> > > The vote will be open for at least 72 hours or until necessary number
> of
> > > votes are reached.
> > >
> > > Please vote accordingly:
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > Checklist for reference:
> > > [ ] Download links are valid.
> > > [ ] Checksums and PGP signatures are valid.
> > > [ ] DISCLAIMER is included.
> > > [ ] LICENSE and NOTICE files are good.
> > > [ ] No binary file.
> > > [ ] All files have license headers if necessary.
> > >
> > > And below is a more detailed checklist:
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> > >
> > > Thanks,
> > > Ming Wen, Apache APISIX
> > > Twitter: _WenMing
> > >
> >
>

Reply via email to