+1 ( binding ) I checked the following.
1. Incubating in name. 2. PGP Signature. 3. SHA512 Checksum. 4. DISCLAIMER exists. 5. LICENSE and NOTICE are fine. 6. No unexpected binary files. Regards Kevin On Tue, Nov 19, 2019 at 9:41 AM YuanSheng Wang <membp...@gmail.com> wrote: > +1 (binding) > > I checked: > - incubating in name > - signatures and hashes fine > - DISCLAIMER exists > - LICENSE and NOTICE good > - no unexpected binary files in release > - all source file have ASF headers > > After downloading the tar package and installing the dependencies, it is > normal. > Then I start the Apache APISIX server by `make run` and make a simple test, > it works fine. > > $ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -X PUT -d ' > { > "uri": "/index.html", > "plugins": { > "limit-count": { > "count": 2, > "time_window": 60, > "rejected_code": 503, > "key": "remote_addr" > } > }, > "upstream": { > "type": "roundrobin", > "nodes": { > "39.97.63.215:80": 1 > } > } > }' > > $ curl http://127.0.0.1:9080/index.html > <html> > <head><title>404 Not Found</title></head> > <body> > <center><h1>404 Not Found</h1></center> > <hr><center>openresty</center> > </body> > </html> > > $ curl http://127.0.0.1:9080/index.html > <html> > <head><title>404 Not Found</title></head> > <body> > <center><h1>404 Not Found</h1></center> > <hr><center>openresty</center> > </body> > </html> > > $ curl http://127.0.0.1:9080/index.html -i > HTTP/1.1 503 Service Temporarily Unavailable > Date: Tue, 19 Nov 2019 04:04:22 GMT > Content-Type: text/html > Content-Length: 194 > Connection: keep-alive > Server: APISIX web server > ... ... > > On Tue, Nov 19, 2019 at 10:57 AM JinChao Shuai <shuaijinc...@apache.org> > wrote: > > > Hi, > > > > +1 (binding) > > > > I checked: > > - incubating in name > > - signatures and hashes fine > > - DISCLAIMER exists > > - LICENSE and NOTICE good > > - no unexpected binary files in release > > - all source file have ASF headers > > > > Tested using the CentOS7 system, the verification, compilation, > > installation, and startup process are normal. > > Server Info: > > LSB Version: core-4.1-amd64:core-4.1-noarch > > Distributor ID: CentOS > > Description: CentOS Linux release 7.6.1810 (Core) > > Release: 7.6.1810 > > Codename: Core > > Note: > > There is no verification in the macOS system and other Linux > > distributions. > > > > > > Justin Mclean <jus...@classsoftware.com> 于2019年11月19日周二 上午5:25写道： > > > > > Hi, > > > > > > +1 (binding) > > > > > > This should probably be called RC2 (RC stands for release candidate). > > > Putting it in the same spot as the previous one can be confusing. > > > > > > I checked: > > > - incubating in name > > > - signatures and hashes fine > > > - DISCLAIMER exists > > > - LICENSE and NOTICE good > > > - no unexpected binary files in release > > > - all source file have ASF headers > > > - can compile but not sure if it's correct (on OSX) > > > > > > I think the compile instructions can be improved as they are unclear. > > Some > > > of the make commands fail to work e.g. "make check” and running the > > binary > > > gives this error: > > > ./apisix:77: module 'tinyyaml' not found: I assume this is just my > > > environment. > > > > > > Thanks, > > > Justin > > > > > -- > > *MembPhis* > My github: https://github.com/membphis > Apache APISIX: https://github.com/apache/incubator-apisix >
