+1 (binding) I checked:
- download links are valid - signatures and hashes fine - DISCLAIMER exists - LICENSE and NOTICE good - No binary file - all source file have ASF headers - compiled and ran quick start on MacOS BTW, I use the *ack -L "(ASF)"* command to search files without that string, so I could know which file doesn't have ASF header. Does there have any other ways? [image: image.png] Best Regards! @ Zhiyuan Ju <https://www.shaoyaoju.org/> JinChao Shuai <shuaijinc...@apache.org> 于2020年1月6日周一 下午1:25写道： > +1 ( binding ) > > I checked: > - download links are valid > - signatures and hashes fine > - DISCLAIMER exists > - LICENSE and NOTICE good > - No binary file. > - all source file have ASF headers > - compiled and ran quick start on CentOS 7 > > test environment: > LSB Version: core-4.1-amd64:core-4.1-noarch > Distributor ID: CentOS > Description: CentOS Linux release 7.6.1810 (Core) > Release: 7.6.1810 > Codename: Core > > Ming Wen <wenm...@apache.org> 于2020年1月6日周一 下午12:51写道： > > > Welcome mentors and more PPMC to vote. > > > > Thanks, > > Ming Wen, Apache APISIX > > Twitter: _WenMing > > > > > > 李凌 <lilien1...@gmail.com> 于2020年1月3日周五 下午5:47写道： > > > > > +1 ( binding ) > > > > > > I checked: > > > - download links are valid > > > - signatures and hashes fine > > > - DISCLAIMER exists > > > - LICENSE and NOTICE good > > > - no binary files in release > > > - all source file have ASF headers > > > - compiled and ran quick start on macOS > > > > > > junxu chen <chenju...@apache.org> 于2020年1月3日周五 下午4:44写道： > > > > > > > > +1 ( binding ) > > > > > > > > I checked: > > > > - download links are valid > > > > - signatures and hashes fine > > > > - DISCLAIMER exists > > > > - LICENSE and NOTICE good > > > > - no binary files in release > > > > - all source file have ASF headers > > > > - compiled and ran quick start on macOS > > > > > > > > On Fri, Jan 3, 2020 at 4:10 PM Ming Wen <wenm...@apache.org> wrote: > > > > > > > > > Hi, > > > > > +1 (binding) > > > > > > > > > > I just checked: > > > > > - Download links are valid. > > > > > - Checksums and PGP signatures are valid. > > > > > - DISCLAIMER is included. > > > > > - LICENSE and NOTICE files are good. > > > > > - No binary file. > > > > > - All files have license headers if necessary. > > > > > > > > > > And one minor thing: not update to `2020` in the NOTICE file. We > can > > > > > update this file in next release. > > > > > > > > > > Thanks, > > > > > Ming Wen, Apache APISIX > > > > > Twitter: _WenMing > > > > > > > > > > > > > > > YuanSheng Wang <membp...@apache.org> 于2020年1月3日周五 下午3:58写道： > > > > > > > > > > > Hello, Community, > > > > > > > > > > > > This is a call for the vote to release Apache APISIX (Incubating) > > > version > > > > > > 1.0-RC1. > > > > > > > > > > > > > > > > > > Release notes: > > > > > > > > > > > > > > > https://github.com/apache/incubator-apisix/blob/v1.0/CHANGELOG.md#100 > > > > > > > > > > > > > > > > > > The release candidates: > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/apisix/1.0-rc1/ > > > > > > > > > > > > > > > > > > Git tag for the release: > > > > > > > > > > > > https://github.com/apache/incubator-apisix/tree/v1.0 > > > > > > > > > > > > > > > > > > Release Commit ID: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-apisix/commit/7c4ecb5a9e540c109caf590009b6d4bcfd163fe1 > > > > > > > > > > > > > > > > > > Keys to verify the Release Candidate: > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/apisix/KEYS > > > > > > > > > > > > > > > > > > Steps to validating the release: > > > > > > > > > > > > 1. Download the release > > > > > > > > > > > > ``` > > > > > > > > > > > > wget > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/apisix/1.0-rc1/apache-apisix-1.0-rc1-incubating-src.tar.gz > > > > > > > > > > > > ``` > > > > > > > > > > > > > > > > > > 2. Checksums and signatures > > > > > > > > > > > > ``` > > > > > > > > > > > > wget > https://dist.apache.org/repos/dist/dev/incubator/apisix/KEYS > > > > > > > > > > > > wget > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/apisix/1.0-rc1/apache-apisix-1.0-rc1-incubating-src.tar.gz.asc > > > > > > > > > > > > wget > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/apisix/1.0-rc1/apache-apisix-1.0-rc1-incubating-src.tar.gz.sha512 > > > > > > > > > > > > > > > > > > shasum -c apache-apisix-1.0-rc1-incubating-src.tar.gz.sha512 > > > > > > > > > > > > > > > > > > gpg --import KEYS > > > > > > > > > > > > # input `trust`, `5`, then `save` > > > > > > > > > > > > gpg --edit-key "Yuansheng Wang" > > > > > > > > > > > > gpg --verify apache-apisix-1.0-rc1-incubating-src.tar.gz.asc > > > > > > apache-apisix-1.0-rc1-incubating-src.tar.gz > > > > > > > > > > > > ``` > > > > > > > > > > > > > > > > > > 3. Unzip and Check files > > > > > > > > > > > > ``` > > > > > > > > > > > > tar zxvf apache-apisix-1.0-rc1-incubating-src.tar.gz > > > > > > > > > > > > ``` > > > > > > > > > > > > > > > > > > 4. Build Apache APISIX: > > > > > > > > > > > > > > > > https://github.com/apache/incubator-apisix/blob/v1.0/doc/how-to-build.md > > > > > > > > > > > > > > > > > > The vote will be open for at least 72 hours or until necessary > > > number of > > > > > > votes are reached. > > > > > > > > > > > > > > > > > > Please vote accordingly: > > > > > > > > > > > > > > > > > > [ ] +1 approve > > > > > > > > > > > > [ ] +0 no opinion > > > > > > > > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > > > > > > > > > Checklist for reference: > > > > > > > > > > > > > > > > > > [ ] Download links are valid. > > > > > > > > > > > > [ ] Checksums and PGP signatures are valid. > > > > > > > > > > > > [ ] DISCLAIMER is included. > > > > > > > > > > > > [ ] LICENSE and NOTICE files are good. > > > > > > > > > > > > [ ] No binary file. > > > > > > > > > > > > [ ] All files have license headers if necessary. > > > > > > > > > > > > > > > > > > > > > > > > And below is a more detailed checklist: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > *MembPhis* > > > > > > My github: https://github.com/membphis > > > > > > Apache APISIX: https://github.com/apache/incubator-apisix > > > > > > > > > > > > > > > > > > > -- > Thanks, > Janko >
