+1 (binding)

I check those:

[Y] Download links are valid.
[Y] Checksums and PGP signatures are valid.
[Y] DISCLAIMER is included.
[Y] LICENSE and NOTICE files are good.
[Y] No binary file.
[Y] All files have license headers if necessary.

It works fine on (docker) alpine 3.7, with:
luarocks: 3.2.1
etcd: 3.3.13



Justin Mclean <jus...@classsoftware.com> 于2020年1月6日周一 下午4:29写道:

> Hi,
>
> +1 (binding) Please fix the NOTICE year for the next release.
>
> I checked:
> - incubating in name
> - signatures and hashes are fine
> - Disclaimer exists
> - LICENSE is good
> - NOTICE has wrong year please fix
> - no unexpected binary files
> - all source file have ASF headers
> - can compile from source
>
> The instruction on building from source are not quite incorrect and refer
> to version 0.9.
>
> Thanks,
> Justin

Reply via email to