+1 ( binding ) I checked the following.
1. Incubating in name. 2. PGP Signatures. 3. SHA512 Checksums. 4. DISCLAIMER exists. 5. LICENSE and NOTICE are fine. 6. No unexpected binary files. Regards Kevin On Mon, Jan 6, 2020 at 3:13 PM YuanSheng Wang <membp...@gmail.com> wrote: > Hi: > > I will release a new version later. > > We need to update this version information[1]. > > I am writing a new script to check this. > > [1] > > https://github.com/apache/incubator-apisix/blob/v1.0/lua/apisix/core/version.lua#L18 > > > On Mon, Jan 6, 2020 at 4:29 PM Justin Mclean <jus...@classsoftware.com> > wrote: > > > Hi, > > > > +1 (binding) Please fix the NOTICE year for the next release. > > > > I checked: > > - incubating in name > > - signatures and hashes are fine > > - Disclaimer exists > > - LICENSE is good > > - NOTICE has wrong year please fix > > - no unexpected binary files > > - all source file have ASF headers > > - can compile from source > > > > The instruction on building from source are not quite incorrect and refer > > to version 0.9. > > > > Thanks, > > Justin > > > > -- > > *MembPhis* > My github: https://github.com/membphis > Apache APISIX: https://github.com/apache/incubator-apisix >
