On 9/19/06, Bojan Smojver <[EMAIL PROTECTED]> wrote:
On Tue, 2006-09-19 at 10:39 -0400, Garrett Rooney wrote:> I would avoid locking when pool isn't NULL, Not exactly sure what you mean. The patch does this in all places where mutex is supposed to get locked: --------------------------------------- +#if APR_HAS_THREADS + if (!pool) { + apr_thread_mutex_lock(dso_global_mutex); + } +#endif /* APR_HAS_THREADS */ --------------------------------------- So, when pool isn't NULL, there is no locking. Or were you referring to something else?
I must not have been paying attention. One other thing that occurs to me though, you need to ifdef around the declaration of the dso mutex, if we don't have threads that type won't be declared. -garrett
