> On 30 Aug 2018, at 07:20, William A Rowe Jr <wr...@rowe-clan.net> wrote: > > This was my workaround for 1.6.x, more eyeballs and feedback welcome.
Looks fine to me. I've dug deep in memory for that change: it was down to protecting a caller who had fed bad inputs to apr_time_exp_get. The broken change was additional to the fix, as it appeared to be another case of the same thing. Reviewing your fix, it does what that should've done and gets it right. At least for callers who take any notice of returned errors! -- Nick Kew
