On 09/15/2018 08:16 PM, William A Rowe Jr wrote:
No worries, thanks for all the follow up.

I am a little concerned that some 'fix' in a later ptf has changed poll semantics in an undesirable way, but we will just be patient and wait for word.

Again, TY,


Small annoying patch :


*** locks/unix/proc_mutex.c_backup      Wed May 24 15:24:15 2017
--- locks/unix/proc_mutex.c     Sat Sep 15 22:40:29 2018
***************
*** 425,431 ****
              return rv;
          }
      }
! if (munmap(mutex->os.pthread_interproc, sizeof(proc_pthread_mutex_t))) {
          return errno;
      }
      return APR_SUCCESS;
--- 425,431 ----
              return rv;
          }
      }
! if (munmap((void*)mutex->os.pthread_interproc, sizeof(proc_pthread_mutex_t))) {
          return errno;
      }
      return APR_SUCCESS;
***************
*** 443,449 ****
          return errno;
      }

! new_mutex->os.pthread_interproc = mmap(NULL, sizeof(proc_pthread_mutex_t), PROT_READ | PROT_WRITE, MAP_SHARED,
                                             fd, 0);
      if (new_mutex->os.pthread_interproc == MAP_FAILED) {
--- 443,450 ----
          return errno;
      }

!     new_mutex->os.pthread_interproc = (pthread_mutex_t*)mmap(NULL,
!                                            sizeof(proc_pthread_mutex_t),
PROT_READ | PROT_WRITE, MAP_SHARED,
                                             fd, 0);
      if (new_mutex->os.pthread_interproc == MAP_FAILED) {


That takes care of those warnings.

All tests pass and I am now moving on to a rebuild of httpd-trunk using
 the new apr and apr-util and hope to have that running in a few hours.

Dennis

Reply via email to