On Tue, Mar 19, 2019 at 1:51 PM Jim Jagielski <j...@jagunet.com> wrote:
> Under OSX/macOS, whether off_t and/or size_t are long long or long > depends on compile time and the actual platform being compiled for. > To have a universal *.h file, you need those checks for __LP64__ > that are determined during the build of whatever is *using* APR, > and not so much during when APR itself is built. If I adjust to > bypass all Darwin specifics and allow the fall-through, it actually > *creates* a defect on macOS depending on which version we > are building on and which version of Xcode being used. > But not for the specific flavor that is built at that moment, one hopes! > As it is, right now, with the __APPLE__ macro fix I added to > apr-*, all is good from OSX 10.7 (the oldest I have) thru 10.14 > using both official Apple Xcode cc/clang and MacPorts gcc. > Excellent news, thanks for confirming that the fix for BSD didn't disrupt OSX! I'd still love to have someone spotting on AIX, Solaris etc to ensure those even more odd architecture compilers (non-gcc) aren't disrupted by the new ./configure logic.