[
https://issues.apache.org/jira/browse/ARIES-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721073#comment-14721073
]
ASF GitHub Bot commented on ARIES-1387:
---------------------------------------
GitHub user cvgaviao opened a pull request:
https://github.com/apache/aries/pull/27
factored headers and clauses classes and added equals() and hashCode()
issue #ARIES-1387
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cvgaviao/aries ARIES-1387
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/aries/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit 8c466348a0c8bc2b88751536209e898a2ea5a67b
Author: Cristiano Gavião <[email protected]>
Date: 2015-08-29T11:29:20Z
factored headers and clauses classes and added equals() and hashCode()
issue #ARIES-1387
----
> Make Subsystem header items order reproducible
> ----------------------------------------------
>
> Key: ARIES-1387
> URL: https://issues.apache.org/jira/browse/ARIES-1387
> Project: Aries
> Issue Type: Improvement
> Components: Subsystem
> Reporter: Cristiano Gavião
>
> Currently the org.apache.aries.subsystem.core.archive.SubsystemContentHeader
> class (line 210) and other headers classes uses a HashSet in order to hold
> its clauses.
> HashSet doesn't ensure the order of its items and then its impossible to have
> a reproducible build of any manifest file. As the SubsystemManifest class
> doesn't provide a equals() method, we can't compare a generated manifest file
> with any template in a test, it will fail.
> The propose it to change the used HashSet for the LinkedHashSet class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
