[
https://issues.apache.org/jira/browse/ARIES-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721127#comment-14721127
]
John Ross commented on ARIES-1387:
----------------------------------
I've only glanced at the pull request, but you're obviously serious about this.
I would like to understand the ultimate intent here. All of these classes are
currently private to the subsystem-core bundle and intended to be so. Is your
expectation that they will now be exported or considered as API? I would be
very hesitant about this. It could hog-tie our ability to make both necessary
and desired changes to the core implementation. How will they be used and what
will be dependent on them?
> Make Subsystem header items order reproducible
> ----------------------------------------------
>
> Key: ARIES-1387
> URL: https://issues.apache.org/jira/browse/ARIES-1387
> Project: Aries
> Issue Type: Improvement
> Components: Subsystem
> Reporter: Cristiano Gavião
>
> Currently the org.apache.aries.subsystem.core.archive.SubsystemContentHeader
> class (line 210) and other headers classes uses a HashSet in order to hold
> its clauses.
> HashSet doesn't ensure the order of its items and then its impossible to have
> a reproducible build of any manifest file. As the SubsystemManifest class
> doesn't provide a equals() method, we can't compare a generated manifest file
> with any template in a test, it will fail.
> The propose it to change the used HashSet for the LinkedHashSet class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
