----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62129/#review184749 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java Lines 228 (patched) <https://reviews.apache.org/r/62129/#comment260951> This is needed only for String type attributes, right? repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java Lines 239 (patched) <https://reviews.apache.org/r/62129/#comment260949> This was necessary only for NEQ cases, right? For comparators like EQ, I think it will be efficient to apply index filter first and apply in-memory filter to get rid of incorrect matches. repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java Line 325 (original), 326 (patched) <https://reviews.apache.org/r/62129/#comment260950> Can attrVal be other type of collection, like Set? If yes, use Collection, instead of list here. - Madhan Neethiraj On Sept. 6, 2017, 6:45 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62129/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 6:45 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-2117 > https://issues.apache.org/jira/browse/ATLAS-2117 > > > Repository: atlas > > > Description > ------- > > See JIRA > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 0daab030 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > d5e39236 > repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java > fc973e6f > > > Diff: https://reviews.apache.org/r/62129/diff/1/ > > > Testing > ------- > > UI and REST calls working as expected now. > > > Thanks, > > Apoorv Naik > >
