> On Sept. 14, 2017, 2:55 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > > Lines 232 (patched) > > <https://reviews.apache.org/r/62129/diff/4/?file=1821427#file1821427line232> > > > > Instead of completely rejecting index-query on detecting NEQ on a > > string attribute, consider treating this as a non-indexed attribute (line > > #240) - so that index-query can handle other attributes and this attribute > > can be handled by graph query or in-memory query.
That's a good idea, I think it's better to move this section in attribute processing call and any such violation should mark the attribute to be filtered by graph. Will update the review shortly - Apoorv ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62129/#review185363 ----------------------------------------------------------- On Sept. 14, 2017, 2:32 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62129/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2017, 2:32 a.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-2117 > https://issues.apache.org/jira/browse/ATLAS-2117 > > > Repository: atlas > > > Description > ------- > > See JIRA > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > ddf117fa > > > Diff: https://reviews.apache.org/r/62129/diff/4/ > > > Testing > ------- > > UI and REST calls working as expected now. > > > Thanks, > > Apoorv Naik > >
