> On Sept. 6, 2017, 10:36 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > > Lines 228 (patched) > > <https://reviews.apache.org/r/62129/diff/1/?file=1816577#file1816577line236> > > > > This is needed only for String type attributes, right?
Yes that's correct, I'll modify the check to take the type into consideration as well. - Apoorv ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62129/#review184749 ----------------------------------------------------------- On Sept. 6, 2017, 11:38 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62129/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 11:38 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-2117 > https://issues.apache.org/jira/browse/ATLAS-2117 > > > Repository: atlas > > > Description > ------- > > See JIRA > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 0daab030 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > d5e39236 > repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java > fc973e6f > > > Diff: https://reviews.apache.org/r/62129/diff/2/ > > > Testing > ------- > > UI and REST calls working as expected now. > > > Thanks, > > Apoorv Naik > >
