----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62255/#review185256 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Sept. 12, 2017, 6:52 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62255/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2017, 6:52 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-2129 > https://issues.apache.org/jira/browse/ATLAS-2129 > > > Repository: atlas > > > Description > ------- > > **Background** > Existing implementation of _bulkImport_ was done in single transaction. This > can potentially lead to case where abrupt shutdown of Atlas during Import > will not retain entities already imported, this renders resume Import > cability useless. > > **Implementation** > - Removed _GraphTransaction_ from _bulkImport_. > - New method _createOrUpdateForImport_ which is under trasaction scope. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 1c168b4 > > > Diff: https://reviews.apache.org/r/62255/diff/1/ > > > Testing > ------- > > **Unit tests** > No new tests added. > > **Functional tests** > Import API tested. > > > Thanks, > > Ashutosh Mestry > >
