----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62255/ -----------------------------------------------------------
(Updated Sept. 14, 2017, 10:04 p.m.) Review request for atlas and Madhan Neethiraj. Changes ------- Updates include: - Modification to _GraphTransactionInterceptor_ to manually control transactions. - Addressed reason for re-open of bug. - Updated description with additional details. Bugs: ATLAS-2129 https://issues.apache.org/jira/browse/ATLAS-2129 Repository: atlas Description (updated) ------- **Background** Existing implementation of _bulkImport_ was done in single transaction. This can potentially lead to case where abrupt shutdown of Atlas during Import will not retain entities already imported, this renders resume Import cability useless. Spring DI does not support case where from within a class annotated method is invoked. The method interception does not happen. This is a known limitation. In the current code base, _Guice_ is used as DI framework. This caused the case where the issue did not get detected from unit tests. Also, the UI does not render correctly when new code is deployed. This caused failure during visual inspection. Work around is to use a clean browser using _incognito_ mdoe for each test. Cache busting mechanism has been implemented, this should address this situation. **Implementation** - Removed _GraphTransaction_ from _bulkImport_. - New method _createOrUpdateForImport_ which is under trasaction scope. Diffs (updated) ----- repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java c6a4bbe repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java a4163f2 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java dc6416a repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 0d8b026 Diff: https://reviews.apache.org/r/62255/diff/2/ Changes: https://reviews.apache.org/r/62255/diff/1-2/ Testing ------- **Unit tests** No new tests added. **Functional tests** Import API tested. Thanks, Ashutosh Mestry