-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62255/
-----------------------------------------------------------

(Updated Sept. 14, 2017, 11:41 p.m.)


Review request for atlas and Madhan Neethiraj.


Changes
-------

Updates include:
- Changed approach to addressing the problem.
- New interface & class _BulkImporter_ & _BulkImporterImpl_.
- Refactored _ImportServiceTest_.


Bugs: ATLAS-2129
    https://issues.apache.org/jira/browse/ATLAS-2129


Repository: atlas


Description
-------

**Background**
Existing implementation of _bulkImport_ was done in single transaction. This 
can potentially lead to case where abrupt shutdown of Atlas during Import will 
not retain entities already imported, this renders resume Import cability 
useless.

Spring DI does not support case where from within a class annotated method is 
invoked. The method interception does not happen. This is a known limitation.

In the current code base, _Guice_ is used as DI framework. This caused the case 
where the issue did not get detected from unit tests.

Also, the UI does not render correctly when new code is deployed. This caused 
failure during visual inspection. Work around is to use a clean browser using 
_incognito_ mdoe for each test. Cache busting mechanism has been implemented, 
this should address this situation.

**Implementation**
- Removed _GraphTransaction_ from _bulkImport_.
- New method _createOrUpdateForImport_ which is under trasaction scope.


Diffs (updated)
-----

  
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 
bbe9ed0 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 a4163f2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/BulkImporter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
 dc6416a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java
 PRE-CREATION 
  repository/src/test/java/org/apache/atlas/TestModules.java 9efbb77 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
 a3fb521 


Diff: https://reviews.apache.org/r/62255/diff/4/

Changes: https://reviews.apache.org/r/62255/diff/3-4/


Testing (updated)
-------

**Unit tests**
- Executed refactored unit tests.

**Functional tests**
- Import API tested.
- Import validated via UI (on multiple browsers).
- Verified abrupt abort scenario.


Thanks,

Ashutosh Mestry

Reply via email to