> On Nov. 30, 2017, 6:47 a.m., David Radley wrote: > > pom.xml > > Line 673 (original), 674 (patched) > > <https://reviews.apache.org/r/64141/diff/1/?file=1903423#file1903423line674> > > > > The titan0 build failed for me because it was looking for JanusGraph. I > > think that this was because the configuration file was not generated for > > Titan 0.
the default backend is to use JanusGraph, if titan is needed, add atlas.graphdb.backend=org.apache.atlas.repository.graphdb.titan0.Titan0GraphDatabase in atlas-application.preoperties > On Nov. 30, 2017, 6:47 a.m., David Radley wrote: > > pom.xml > > Line 676 (original), 677 (patched) > > <https://reviews.apache.org/r/64141/diff/1/?file=1903423#file1903423line677> > > > > It seems odd to have a profile that specifies elastic search and > > excludes the elastic search. we are excluding elastic search jars since we build shaded jar atlas-graphdb-titan0.jar which includes dependent ES libraries > On Nov. 30, 2017, 6:47 a.m., David Radley wrote: > > pom.xml > > Lines 679 (patched) > > <https://reviews.apache.org/r/64141/diff/1/?file=1903423#file1903423line679> > > > > why are we excluding titan jar file for a titan profile ? same as above the shaded jar atlas-graphdb-titan0.jar contains titan libraries excluding it to avoid duplicate > On Nov. 30, 2017, 6:47 a.m., David Radley wrote: > > pom.xml > > Lines 700 (patched) > > <https://reviews.apache.org/r/64141/diff/1/?file=1903423#file1903423line700> > > > > I suggest we remove this profile agreed. will remove it > On Nov. 30, 2017, 6:47 a.m., David Radley wrote: > > pom.xml > > Line 717 (original), 720 (patched) > > <https://reviews.apache.org/r/64141/diff/1/?file=1903423#file1903423line720> > > > > So the default Janus profile have solr.embedded. Does this mean that it > > will not work with external solr now? This is a test only property that tells maven to start/stop solr instances during unit tests. There is no hard dependency on Solr during runtime. Will rename the property to a more intuitive name. > On Nov. 30, 2017, 6:47 a.m., David Radley wrote: > > pom.xml > > Lines 721 (patched) > > <https://reviews.apache.org/r/64141/diff/1/?file=1903423#file1903423line721> > > > > I wonder why you are excluding je -* files here . Do they cause a > > problem? Due to licensing requirements, Atlas does not bundle the BerkeleyDB Java Edition in the tarball. - Sarath ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64141/#review192267 ----------------------------------------------------------- On Nov. 28, 2017, 6:32 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64141/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2017, 6:32 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2287 > https://issues.apache.org/jira/browse/ATLAS-2287 > > > Repository: atlas > > > Description > ------- > > When Atlas is build using -Pdist profile, lucene jars are excluded during > packaging of the war file. Since we are not shading graphdb module for janus > profile, these jars are needed as run time dependency. > Titan's shaded jar includes the lucene libraries and hence were excluded > during packaging of war to avoid duplicate dependencies. > > > Diffs > ----- > > distro/pom.xml eea256d8 > pom.xml 3720c1f5 > webapp/pom.xml b4a96d36 > > > Diff: https://reviews.apache.org/r/64141/diff/1/ > > > Testing > ------- > > validated building atlas distribution using both janus and titan0 profile. > Atlas starts fine and basic functionalities working. > > mvn clean install -DskipTests -Pdist,embedded-hbase-solr > mvn clean install -DskipTests -Pdist,embedded-hbase-solr > -DGRAPH-PROVIDER=titan0 > > > Thanks, > > Sarath Subramanian > >
