----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71160/#review216860 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java Lines 61 (patched) <https://reviews.apache.org/r/71160/#comment304109> isValidValue() should mirror the logic in getNormalizedValue() - which uses Boolean.valueOf() to convert obj to a Boolean. With this logic, there is no invalid value for Boolean type. Please review and update. intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java Lines 107 (patched) <https://reviews.apache.org/r/71160/#comment304110> Instead of validateNumberRange() that handles multiple types (byte/short/int/long/float/double/..), consider adding isValidRange(Number num) to corresponding Atlas*Type classes, and have getNormalizedValue() use this method: - AtlasByteType.isValidRange(Number num) - AtlasShortType.isValidRange(Number num) - AtlasIntType.isValidRange(Number num) - AtlasLongType.isValidRange(Number num) - AtlasFloatType.isValidRange(Number num) - AtlasDoubleType.isValidRange(Number num) - .. - Madhan Neethiraj On July 25, 2019, 1:26 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71160/ > ----------------------------------------------------------- > > (Updated July 25, 2019, 1:26 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3347 > https://issues.apache.org/jira/browse/ATLAS-3347 > > > Repository: atlas > > > Description > ------- > > This patch handles data type value exceeding and throws proper exception when > we create Relationship entity. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ce14b5b > > > Diff: https://reviews.apache.org/r/71160/diff/2/ > > > Testing > ------- > > Testing done Lower limit and Upper limit of primitive datatypes. > > Work in progress as some test cases are failing. > > > Thanks, > > Mandar Ambawane > >
