----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71160/#review216892 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java Lines 63 (patched) <https://reviews.apache.org/r/71160/#comment304136> Given getNormalizedValue() returns null only when obj is null, it will be efficient to replace this method body to return true - just as the earlier implementation. intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java Lines 405 (patched) <https://reviews.apache.org/r/71160/#comment304142> Math.abs() usage here doesn't look right. Please replace use of "Float.MIN_VALUE" with "-Float.MAX_VALUE". From: https://docs.oracle.com/javase/8/docs/api/java/lang/Float.html MIN_VALUE A constant holding the smallest positive nonzero value of type float, 2-149. intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java Lines 491 (patched) <https://reviews.apache.org/r/71160/#comment304143> Math.abs() usage here doesn't look right. Please replace use of "Double.MIN_VALUE" with "-Double.MAX_VALUE". From: https://docs.oracle.com/javase/8/docs/api/java/lang/Double.html MIN_VALUE A constant holding the smallest positive nonzero value of type double, 2-1074. - Madhan Neethiraj On July 26, 2019, 11:19 a.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71160/ > ----------------------------------------------------------- > > (Updated July 26, 2019, 11:19 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3347 > https://issues.apache.org/jira/browse/ATLAS-3347 > > > Repository: atlas > > > Description > ------- > > This patch handles data type value exceeding and throws proper exception when > we create Relationship entity. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ce14b5b > > > Diff: https://reviews.apache.org/r/71160/diff/3/ > > > Testing > ------- > > Testing done Lower limit and Upper limit of primitive datatypes. > > Work in progress as some test cases are failing. > > > Thanks, > > Mandar Ambawane > >
