-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71160/
-----------------------------------------------------------
(Updated July 28, 2019, 6:22 p.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues,
and Sarath Subramanian.
Changes
-------
Addressed review comments and handled test-cases for boolean datatype.
Bugs: ATLAS-3347
https://issues.apache.org/jira/browse/ATLAS-3347
Repository: atlas
Description
-------
This patch handles data type value exceeding and throws proper exception when
we create Relationship entity.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ce14b5b
Diff: https://reviews.apache.org/r/71160/diff/4/
Changes: https://reviews.apache.org/r/71160/diff/3-4/
Testing (updated)
-------
Testing done Lower limit and Upper limit of primitive datatypes.
Here, I have made changes for lower and upper limit for float and double.
Also for boolean datatype I have handled scenarios mentioned in jira.
In case of boolean, we need to compare here actual content of the input string,
because Boolean constructor with string as an argument considers everything
false other than argument case in-sensitive "true".
Also here for input as null to the method getNormalizedValue() we cannnot
return value true, It will break test-case
testBooleanTypeGetNormalizedValue()
Thanks,
Mandar Ambawane
