----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71160/#review217005 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On July 31, 2019, 12:36 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71160/ > ----------------------------------------------------------- > > (Updated July 31, 2019, 12:36 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3347 > https://issues.apache.org/jira/browse/ATLAS-3347 > > > Repository: atlas > > > Description > ------- > > This patch handles data type value exceeding and throws proper exception when > we create Relationship entity. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ce14b5b > intg/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java ec5f75a > intg/src/test/java/org/apache/atlas/type/TestAtlasByteType.java a7ada38 > intg/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java b3cbe72 > intg/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java 64fc3e3 > intg/src/test/java/org/apache/atlas/type/TestAtlasIntType.java c2b5eb4 > intg/src/test/java/org/apache/atlas/type/TestAtlasLongType.java 7eefcc2 > intg/src/test/java/org/apache/atlas/type/TestAtlasShortType.java 2b15ba0 > > > Diff: https://reviews.apache.org/r/71160/diff/6/ > > > Testing > ------- > > Testing done Lower limit and Upper limit of primitive datatypes. > > Here, I have made changes for lower and upper limit for float and double. > > Also for boolean datatype I have handled scenarios mentioned in jira. > > In case of boolean, we need to compare here actual content of the input > string, because Boolean constructor with string as an argument considers > everything false other than argument case in-sensitive "true". > > Also here for input as null to the method getNormalizedValue() we cannnot > return value true, It will break test-case > testBooleanTypeGetNormalizedValue() > > > Thanks, > > Mandar Ambawane > >
