----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72474/#review220702 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java Lines 217 (patched) <https://reviews.apache.org/r/72474/#comment309329> consider refactoring to: GremlinClause gremlinClauseForEdgeLabel = org.getEdgeDirection().equals("IN") ? GremlinClause.OUT : GremlinClause.IN; add(gremlinClauseForEdgeLabel, org.getEdgeLabel()); repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java Lines 583 (patched) <https://reviews.apache.org/r/72474/#comment309330> consider refactoring simialr to above. repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java Lines 131 (patched) <https://reviews.apache.org/r/72474/#comment309327> consider updating edgeDirection type to AtlasRelationshipEdgeDirection (enum) repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java Line 160 (original), 163 (patched) <https://reviews.apache.org/r/72474/#comment309328> why change ex.getMessage()? revert if not intended. - Sarath Subramanian On May 9, 2020, 1:13 a.m., chaitali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72474/ > ----------------------------------------------------------- > > (Updated May 9, 2020, 1:13 a.m.) > > > Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Nixon Rodrigues, and > Sarath Subramanian. > > > Bugs: ATLAS-3783 > https://issues.apache.org/jira/browse/ATLAS-3783 > > > Repository: atlas > > > Description > ------- > > Unable to get results for Dsl query eg;hive_column where > table.name="employee". > Due to regression only one edge direction was giving results. > This patch gives a fix for results for both relationship edge direction > queries. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java > 04b177533 > repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java > 6ab61e16b > repository/src/main/java/org/apache/atlas/query/Lookup.java 3c192d824 > repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java > 2b34abff8 > repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java > 0bbff2f46 > > repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java > 6f4df88f0 > > > Diff: https://reviews.apache.org/r/72474/diff/6/ > > > Testing > ------- > > TestCases added. > > > Thanks, > > chaitali > >
