> On May 11, 2020, 6:02 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java > > Lines 220 (patched) > > <https://reviews.apache.org/r/72474/diff/8/?file=2231131#file2231131line220> > > > > both if and else condition executes the same statement. please review.
Here in Gremlin composer if we are receiving relationshipedgedirection for the second edge when it comes to this IF condition then the logic is if (direction is "IN" then set GremlinClause as "OUT". and if direction is "OUT" then set GremlinClause as "IN".)Hence am executing it twice. > On May 11, 2020, 6:02 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java > > Lines 591 (patched) > > <https://reviews.apache.org/r/72474/diff/8/?file=2231131#file2231131line591> > > > > same here. remove if/else condition Here in Gremlin composer if we are receiving relationshipedgedirection for the First edge when it comes to this IF condition where the logic is if (direction is "IN" then set GremlinClause as "IN". and if direction is "OUT" then set GremlinClause as "OUT".)Hence am executing it twice. - chaitali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72474/#review220707 ----------------------------------------------------------- On May 11, 2020, 5:56 p.m., chaitali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72474/ > ----------------------------------------------------------- > > (Updated May 11, 2020, 5:56 p.m.) > > > Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Nixon Rodrigues, and > Sarath Subramanian. > > > Bugs: ATLAS-3783 > https://issues.apache.org/jira/browse/ATLAS-3783 > > > Repository: atlas > > > Description > ------- > > Unable to get results for Dsl query eg;hive_column where > table.name="employee". > Due to regression only one edge direction was giving results. > This patch gives a fix for results for both relationship edge direction > queries. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java > 04b177533 > repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java > 6ab61e16b > repository/src/main/java/org/apache/atlas/query/Lookup.java 3c192d824 > repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java > 2b34abff8 > repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java > 0bbff2f46 > > repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java > 6f4df88f0 > > > Diff: https://reviews.apache.org/r/72474/diff/8/ > > > Testing > ------- > > TestCases added. > > > Thanks, > > chaitali > >
