> On May 11, 2020, 6:25 a.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java
> > Line 160 (original), 163 (patched)
> > <https://reviews.apache.org/r/72474/diff/6/?file=2231084#file2231084line163>
> >
> > why change ex.getMessage()? revert if not intended.
>
> chaitali wrote:
> While running testcases no valid error was thrown when testcase caught
> null which made it complicated to trace the error
> .So i have added this error message to notify
org.apache.atlas.exception.AtlasBaseException: Invalid DSL query: hive_db as d
select d | Reason: . Please refer to Atlas DSL grammar for more information
at
org.apache.atlas.query.AtlasDSL$Translator.processErrorList(AtlasDSL.java:143)
at
org.apache.atlas.query.AtlasDSL$Translator.translate(AtlasDSL.java:130)
at
org.apache.atlas.discovery.EntityDiscoveryService.toGremlinQuery(EntityDiscoveryService.java:736)
org.apache.atlas.exception.AtlasBaseException: Invalid DSL query: hive_db as d
select d | Reason: NullPointerException. Please refer to Atlas DSL grammar for
more information
at
org.apache.atlas.query.AtlasDSL$Translator.processErrorList(AtlasDSL.java:143)
at
org.apache.atlas.query.AtlasDSL$Translator.translate(AtlasDSL.java:130)
at
org.apache.atlas.discovery.EntityDiscoveryService.toGremlinQuery(EntityDiscoveryService.java:736)
- chaitali
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72474/#review220702
-----------------------------------------------------------
On May 11, 2020, 9:24 a.m., chaitali wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72474/
> -----------------------------------------------------------
>
> (Updated May 11, 2020, 9:24 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Nixon Rodrigues, and
> Sarath Subramanian.
>
>
> Bugs: ATLAS-3783
> https://issues.apache.org/jira/browse/ATLAS-3783
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Unable to get results for Dsl query eg;hive_column where
> table.name="employee".
> Due to regression only one edge direction was giving results.
> This patch gives a fix for results for both relationship edge direction
> queries.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java
> 04b177533
> repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java
> 6ab61e16b
> repository/src/main/java/org/apache/atlas/query/Lookup.java 3c192d824
> repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java
> 2b34abff8
> repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java
> 0bbff2f46
>
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java
> 6f4df88f0
>
>
> Diff: https://reviews.apache.org/r/72474/diff/7/
>
>
> Testing
> -------
>
> TestCases added.
>
>
> Thanks,
>
> chaitali
>
>
