----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/#review221139 -----------------------------------------------------------
client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Line 29 (original), 32 (patched) <https://reviews.apache.org/r/72638/#comment309921> Avoid * instead of individual imports. client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Line 41 (original), 46 (patched) <https://reviews.apache.org/r/72638/#comment309922> Avoid replacing individual imports with '*'. client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 707 (patched) <https://reviews.apache.org/r/72638/#comment309923> Remove: TODO webapp/pom.xml Line 744 (original), 744 (patched) <https://reviews.apache.org/r/72638/#comment309924> Avoid. webapp/src/test/java/org/apache/atlas/web/TestUtils.java Lines 60 (patched) <https://reviews.apache.org/r/72638/#comment309925> Remove. webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java Line 95 (original), 96 (patched) <https://reviews.apache.org/r/72638/#comment309926> Remove comment. webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java Lines 145 (patched) <https://reviews.apache.org/r/72638/#comment309927> Remove comment. webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java Lines 31 (patched) <https://reviews.apache.org/r/72638/#comment309929> Avoid. webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java Lines 46 (patched) <https://reviews.apache.org/r/72638/#comment309928> Avoid. webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java Lines 31 (patched) <https://reviews.apache.org/r/72638/#comment309930> Avoid. webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java Lines 92 (patched) <https://reviews.apache.org/r/72638/#comment309931> Can you investigate loading JSONs instead of hand coding entities. - Ashutosh Mestry On July 6, 2020, 5:53 p.m., Jyoti Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72638/ > ----------------------------------------------------------- > > (Updated July 6, 2020, 5:53 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > ------- > > There are many missing API endpoints in AtlasClientV2. This solution is > adding functions corresponding to those missing APIs for the following Rest > endpoints. > > 1. TypeRest > 2. EntityRest > 3. LineageRest > 4. DiscoveryRest > 5. GlossaryRest > 6. RelationshipRest > > This will enable users to test and integrate with APIs more effectively via > AtlasCient. > > > Diffs > ----- > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > 7b6d1d0f3 > webapp/pom.xml 3c55b4dd4 > webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d > webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java > 680028892 > webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java > 808f62354 > > webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java > cc883d615 > > webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java > 331ea2c47 > webapp/src/test/resources/json/search-parameters/attribute-filters.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/72638/diff/2/ > > > Testing > ------- > > IT has been added for newly created functions in AtlasClientV2. > Validated by running IT on local system. > > > Thanks, > > Jyoti Singh > >
