----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/#review221213 -----------------------------------------------------------
client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Line 40 (original), 57 (patched) <https://reviews.apache.org/r/72638/#comment310029> Please remove this one as its already imported above client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 103 (patched) <https://reviews.apache.org/r/72638/#comment310030> Please maintain the above alignment. client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 112 (patched) <https://reviews.apache.org/r/72638/#comment310032> Align below lines like: //Glossary APIs private static final String GLOSSARY_URI = BASE_URI + "v2/glossary"; private static final String GLOSSARY_TERM = GLOSSARY_URI + "/term"; private static final String GLOSSARY_TERMS = GLOSSARY_URI + "/terms"; private static final String GLOSSARY_CATEGORY = GLOSSARY_URI + "/category"; private static final String GLOSSARY_CATEGORIES = GLOSSARY_URI + "/categories"; client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 118 (patched) <https://reviews.apache.org/r/72638/#comment310031> Please have one blank line instead of two client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 220 (patched) <https://reviews.apache.org/r/72638/#comment310033> Please rename getRelationShipDefByName -> getRelationshipDefByName (As RelationShip is a single word) client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 224 (patched) <https://reviews.apache.org/r/72638/#comment310034> getRelationShipDefByGuid -> getRelationshipDefByGuid client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 597 (patched) <https://reviews.apache.org/r/72638/#comment310035> Please remove these two extra blank lines client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 648 (patched) <https://reviews.apache.org/r/72638/#comment310037> Please remove the below lines as it seems its not bMultivaluedMap<String, String> queryParams = new MultivaluedMapImpl(); queryParams.add("name", name); client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 650 (patched) <https://reviews.apache.org/r/72638/#comment310036> Please remove the commented line - Sidharth Mishra On July 10, 2020, 12:05 a.m., Jyoti Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72638/ > ----------------------------------------------------------- > > (Updated July 10, 2020, 12:05 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > ------- > > There are many missing API endpoints in AtlasClientV2. This solution is > adding functions corresponding to those missing APIs for the following Rest > endpoints. > > 1. TypeRest > 2. EntityRest > 3. LineageRest > 4. DiscoveryRest > 5. GlossaryRest > 6. RelationshipRest > > This will enable users to test and integrate with APIs more effectively via > AtlasCient. > > > Diffs > ----- > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > 7b6d1d0f3 > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 > webapp/pom.xml 3c55b4dd4 > webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d > webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java > 680028892 > webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java > 808f62354 > > webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java > cc883d615 > > webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java > 331ea2c47 > webapp/src/test/resources/json/search-parameters/attribute-filters.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/72638/diff/4/ > > > Testing > ------- > > IT has been added for newly created functions in AtlasClientV2. > Validated by running IT on local system. > > > Thanks, > > Jyoti Singh > >
