----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/#review221235 -----------------------------------------------------------
client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 117 (patched) <https://reviews.apache.org/r/72638/#comment310069> SAVED_URI => SAVED_SEARCH_URI client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 118 (patched) <https://reviews.apache.org/r/72638/#comment310070> QUICK_URI => QUICK_SEARCH_URI client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 132 (patched) <https://reviews.apache.org/r/72638/#comment310071> nit: typo in 'relateed' client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 244 (patched) <https://reviews.apache.org/r/72638/#comment310072> nit: remove additional newline client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 250 (patched) <https://reviews.apache.org/r/72638/#comment310073> getBusinessMetadataDefGuid => getBusinessMetadataDefByGuid client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 525 (patched) <https://reviews.apache.org/r/72638/#comment310074> removeBusinessAttributes => removeBusinessAttributesByName client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 543 (patched) <https://reviews.apache.org/r/72638/#comment310075> setLabels => setLabelsByUniqueAttributes addLabels => addLabelsByUniqueAttributes removeLabels => removeLabelsByUniqueAttributes client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 570 (patched) <https://reviews.apache.org/r/72638/#comment310076> getLineageInfo => getLineageInfoByUniqueAttributes client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 683 (patched) <https://reviews.apache.org/r/72638/#comment310077> nit: additional space after 'void' client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 687 (patched) <https://reviews.apache.org/r/72638/#comment310078> nit: additional space after 'AtlasSearchResult' client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 693 (patched) <https://reviews.apache.org/r/72638/#comment310079> nit: additional space after 'AtlasSearchResult' client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 937 (patched) <https://reviews.apache.org/r/72638/#comment310080> nit: fix alignment line 937-940 client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 1073 (patched) <https://reviews.apache.org/r/72638/#comment310082> DELETE_TYPE_BY_NAME => DELETE_TYPE_DEF_BY_NAME client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 1095 (patched) <https://reviews.apache.org/r/72638/#comment310083> nit: fix alignment from line 1095-1114 client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java Lines 685 (patched) <https://reviews.apache.org/r/72638/#comment310068> this method is not used anywhere. review and revert if not needed. webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java Lines 579 (patched) <https://reviews.apache.org/r/72638/#comment310084> nit: remove additional new line webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java Lines 608 (patched) <https://reviews.apache.org/r/72638/#comment310085> nit: remove additional new line - Sarath Subramanian On July 15, 2020, 8:17 p.m., Jyoti Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72638/ > ----------------------------------------------------------- > > (Updated July 15, 2020, 8:17 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > ------- > > There are many missing API endpoints in AtlasClientV2. This solution is > adding functions corresponding to those missing APIs for the following Rest > endpoints. > > 1. TypeRest > 2. EntityRest > 3. LineageRest > 4. DiscoveryRest > 5. GlossaryRest > 6. RelationshipRest > > This will enable users to test and integrate with APIs more effectively via > AtlasCient. > > > Diffs > ----- > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > 7b6d1d0f3 > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 > webapp/pom.xml 3c55b4dd4 > webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d > webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java > 680028892 > webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java > 808f62354 > > webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java > cc883d615 > > webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java > 331ea2c47 > webapp/src/test/resources/json/search-parameters/attribute-filters.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/72638/diff/5/ > > > Testing > ------- > > IT has been added for newly created functions in AtlasClientV2. > Validated by running IT on local system. > > > Thanks, > > Jyoti Singh > >
