----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/#review221258 -----------------------------------------------------------
client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 472 (patched) <https://reviews.apache.org/r/72638/#comment310114> - please remove 'final' for method parameters - partialUpdateEntityAttrByGuid() => partialUpdateEntityByGuid() client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 490 (patched) <https://reviews.apache.org/r/72638/#comment310115> removeEntityClassifications() => removeEntityClassification() client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 495 (patched) <https://reviews.apache.org/r/72638/#comment310116> deleteClassificationByGuid() => removeEntityClassification() client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 539 (patched) <https://reviews.apache.org/r/72638/#comment310117> importBMAttributes() => bulkUpdateBusinessAttributes() client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 547 (patched) <https://reviews.apache.org/r/72638/#comment310118> entityGuid => typeName? Please review and update. client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 551 (patched) <https://reviews.apache.org/r/72638/#comment310119> entityGuid => typeName? Please review and update. client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 556 (patched) <https://reviews.apache.org/r/72638/#comment310120> exportDataForEntity() => getTemplateForBulkUpdateBusinessAttributes() client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 562 (patched) <https://reviews.apache.org/r/72638/#comment310121> Please remove 'final' from method parameters - line #562, #570. client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 629 (patched) <https://reviews.apache.org/r/72638/#comment310122> For consistency with other methods, I suggest to reorder the parameters: - typeName, attrName, attrValuePrefix, limit, offset client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 775 (patched) <https://reviews.apache.org/r/72638/#comment310123> - please remove 'atlas' prefix from variable names atlasGlossary => glossary - please make sure to leave a space before '{'; here and rest of the patch client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 831 (patched) <https://reviews.apache.org/r/72638/#comment310124> sort => sortByAttribute - lines #831, #842, #853, #863, #873, #884, #894 client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 936 (patched) <https://reviews.apache.org/r/72638/#comment310125> importFileData() => importGlossary() client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 953 (patched) <https://reviews.apache.org/r/72638/#comment310126> importData() => importGlossary() client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 958 (patched) <https://reviews.apache.org/r/72638/#comment310127> performImportData() => importGlossary() client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 972 (patched) <https://reviews.apache.org/r/72638/#comment310128> getTemplateByStream() => readStreamContents() client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 1175 (patched) <https://reviews.apache.org/r/72638/#comment310130> GET_TEMPLATE => GET_IMPORT_GLOSSARY_TEMPLATE client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 1176 (patched) <https://reviews.apache.org/r/72638/#comment310129> IMPORT_DATA => IMPORT_GLOSSARY client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java Lines 685 (patched) <https://reviews.apache.org/r/72638/#comment310131> - hardcoded path "/src/test/resources/" doesn't look right. is this a temp location? or is the user expected have contents under this directory? - if this is needed only for testing, consider moving this to test code. - Madhan Neethiraj On July 16, 2020, 3:17 a.m., Jyoti Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72638/ > ----------------------------------------------------------- > > (Updated July 16, 2020, 3:17 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > ------- > > There are many missing API endpoints in AtlasClientV2. This solution is > adding functions corresponding to those missing APIs for the following Rest > endpoints. > > 1. TypeRest > 2. EntityRest > 3. LineageRest > 4. DiscoveryRest > 5. GlossaryRest > 6. RelationshipRest > > This will enable users to test and integrate with APIs more effectively via > AtlasCient. > > > Diffs > ----- > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > 7b6d1d0f3 > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java e3d2ebc34 > webapp/pom.xml 3c55b4dd4 > webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d > webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java > 680028892 > webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java > 808f62354 > > webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java > cc883d615 > > webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java > 331ea2c47 > webapp/src/test/resources/json/search-parameters/attribute-filters.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/72638/diff/5/ > > > Testing > ------- > > IT has been added for newly created functions in AtlasClientV2. > Validated by running IT on local system. > > > Thanks, > > Jyoti Singh > >
