-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72698/#review221306
-----------------------------------------------------------




atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java
Lines 20 (patched)
<https://reviews.apache.org/r/72698/#comment310188>

    nit: removed unused imports line 20,21



atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java
Lines 134 (patched)
<https://reviews.apache.org/r/72698/#comment310189>

    'url' is never used. consider removing.



atlas-examples/src/main/java/org/apache/atlas/TypeDefExample.java
Lines 58 (patched)
<https://reviews.apache.org/r/72698/#comment310190>

    isCompositeSourceConstraint => isOwnedRefConstraint



atlas-examples/src/main/java/org/apache/atlas/TypeDefExample.java
Lines 59 (patched)
<https://reviews.apache.org/r/72698/#comment310191>

    isCompositeTargetConstraint => isInverseRefConstraint


- Sarath Subramanian


On July 21, 2020, 9:24 a.m., Jyoti Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72698/
> -----------------------------------------------------------
> 
> (Updated July 21, 2020, 9:24 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Using this project users can get an idea as how to integrate with Atlas using 
> AtlasCleint. This helps the user to understand the basic rest functionality 
> of Atlas such as
> 
> - EntityRest
> - TypeDefRest
> - DiscoveryRest
> - LineageRest
> - GlossaryRest
> 
> 
> Diffs
> -----
> 
>   atlas-examples/pom.xml PRE-CREATION 
>   atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java 
> PRE-CREATION 
>   atlas-examples/src/main/java/org/apache/atlas/DiscoveryExample.java 
> PRE-CREATION 
>   atlas-examples/src/main/java/org/apache/atlas/EntityRestBaseExample.java 
> PRE-CREATION 
>   atlas-examples/src/main/java/org/apache/atlas/GlossaryExample.java 
> PRE-CREATION 
>   atlas-examples/src/main/java/org/apache/atlas/LineageExample.java 
> PRE-CREATION 
>   atlas-examples/src/main/java/org/apache/atlas/TypeDefExample.java 
> PRE-CREATION 
>   pom.xml 5e0442ae5 
> 
> 
> Diff: https://reviews.apache.org/r/72698/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jyoti Singh
> 
>

Reply via email to