----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/#review221321 -----------------------------------------------------------
atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java Lines 63 (patched) <https://reviews.apache.org/r/72698/#comment310200> char[] is always preferred over String - check https://stackoverflow.com/questions/8881291/why-is-char-preferred-over-string-for-passwords#:~:text=Since%20Strings%20are%20immutable%20there,2. Please check if we can add a new contructor at client v2 and do this ow lets file a jira and track this for client v2 atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java Lines 75 (patched) <https://reviews.apache.org/r/72698/#comment310202> Please check if we should change the code snippet from 72:84 to something like: public static void main(String[] args) throws Exception { String[] basicAuthUsernamePassword = null; String[] urls = null; urls = getServerUrl(); if (!AuthenticationUtil.isKerberosAuthenticationEnabled()) { basicAuthUsernamePassword = getUserInput(); new AtlasClientBaseExample(urls, basicAuthUsernamePassword); } else { new AtlasClientBaseExample(urls); } try { // TypeDef atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java Lines 83 (patched) <https://reviews.apache.org/r/72698/#comment310201> In case of kerberos urls will be null as we populate that if kerberos not enabled. atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java Lines 86 (patched) <https://reviews.apache.org/r/72698/#comment310203> Instead of commenting like typedef then entity examples etc. it would be good to move these to separate private functions. Please refer - FUNCTIONS SHOULD DO ONE THING. THEY SHOULD DO IT WELL. THEY SHOULD DO IT ONLY (more details - https://learning.oreilly.com/library/view/clean-code/9780136083238/chapter03.html#ch3) https://softwareengineering.stackexchange.com/questions/137941/should-a-method-do-one-thing-and-be-good-at-it atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java Lines 140 (patched) <https://reviews.apache.org/r/72698/#comment310199> Please use Console.readPassword instead - Sidharth Mishra On July 21, 2020, 4:24 p.m., Jyoti Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72698/ > ----------------------------------------------------------- > > (Updated July 21, 2020, 4:24 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > ------- > > Using this project users can get an idea as how to integrate with Atlas using > AtlasCleint. This helps the user to understand the basic rest functionality > of Atlas such as > > - EntityRest > - TypeDefRest > - DiscoveryRest > - LineageRest > - GlossaryRest > > > Diffs > ----- > > atlas-examples/pom.xml PRE-CREATION > atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java > PRE-CREATION > atlas-examples/src/main/java/org/apache/atlas/DiscoveryExample.java > PRE-CREATION > atlas-examples/src/main/java/org/apache/atlas/EntityRestBaseExample.java > PRE-CREATION > atlas-examples/src/main/java/org/apache/atlas/GlossaryExample.java > PRE-CREATION > atlas-examples/src/main/java/org/apache/atlas/LineageExample.java > PRE-CREATION > atlas-examples/src/main/java/org/apache/atlas/TypeDefExample.java > PRE-CREATION > pom.xml 5e0442ae5 > > > Diff: https://reviews.apache.org/r/72698/diff/2/ > > > Testing > ------- > > > Thanks, > > Jyoti Singh > >
