> On July 22, 2020, 7:24 p.m., Sidharth Mishra wrote: > > atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java > > Lines 86 (patched) > > <https://reviews.apache.org/r/72698/diff/2/?file=2236103#file2236103line86> > > > > Instead of commenting like typedef then entity examples etc. it would > > be good to move these to separate private functions. Please refer - > > > > FUNCTIONS SHOULD DO ONE THING. THEY SHOULD DO IT WELL. THEY SHOULD DO > > IT ONLY (more details - > > https://learning.oreilly.com/library/view/clean-code/9780136083238/chapter03.html#ch3) > > > > > > https://softwareengineering.stackexchange.com/questions/137941/should-a-method-do-one-thing-and-be-good-at-it
We need to delete Type and entity at the end so not moving these inside function. - Jyoti ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/#review221321 ----------------------------------------------------------- On July 23, 2020, 6:10 p.m., Jyoti Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72698/ > ----------------------------------------------------------- > > (Updated July 23, 2020, 6:10 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > ------- > > Using this project users can get an idea as how to integrate with Atlas using > AtlasCleint. This helps the user to understand the basic rest functionality > of Atlas such as > > - EntityRest > - TypeDefRest > - DiscoveryRest > - LineageRest > - GlossaryRest > > > Diffs > ----- > > atlas-examples/pom.xml PRE-CREATION > atlas-examples/sample-app/README.md PRE-CREATION > atlas-examples/sample-app/pom.xml PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java > PRE-CREATION > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java > PRE-CREATION > atlas-examples/sample-app/src/main/resources/atlas-application.properties > PRE-CREATION > pom.xml 5e0442ae5 > > > Diff: https://reviews.apache.org/r/72698/diff/3/ > > > Testing > ------- > > > Thanks, > > Jyoti Singh > >