-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73257/#review222741
-----------------------------------------------------------




addons/models/3000-Cloud/3060-gcp_typedefs.json
Lines 32 (patched)
<https://reviews.apache.org/r/73257/#comment311900>

    scp => gcp



addons/models/3000-Cloud/3060-gcp_typedefs.json
Lines 129 (patched)
<https://reviews.apache.org/r/73257/#comment311902>

    Please review if use of an enum is feasible here.



addons/models/3000-Cloud/3060-gcp_typedefs.json
Lines 137 (patched)
<https://reviews.apache.org/r/73257/#comment311903>

    requesterPays - sounds like a boolean value. Please review and update the 
typeName if necessary.


- Madhan Neethiraj


On March 30, 2021, 10:28 p.m., Sidharth Mishra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73257/
> -----------------------------------------------------------
> 
> (Updated March 30, 2021, 10:28 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4226
>     https://issues.apache.org/jira/browse/ATLAS-4226
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Add model types for Google cloud storage
> 
> 
> Diffs
> -----
> 
>   addons/models/3000-Cloud/3060-gcp_typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73257/diff/2/
> 
> 
> Testing
> -------
> 
> Manually tested if the patch application is successful and entity creation is 
> working.
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Reply via email to