-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73257/#review222752
-----------------------------------------------------------




addons/models/3000-Cloud/3060-gcp_typedefs.json
Lines 8 (patched)
<https://reviews.apache.org/r/73257/#comment311929>

    nit: typo - vitual -> virtual



addons/models/3000-Cloud/3060-gcp_typedefs.json
Lines 13 (patched)
<https://reviews.apache.org/r/73257/#comment311930>

    remove 'attributeDefs' and 'superTypes' if empty. Review all other types as 
well



addons/models/3000-Cloud/3060-gcp_typedefs.json
Lines 63 (patched)
<https://reviews.apache.org/r/73257/#comment311931>

    isIndexable can be true ? to enable index search on encryption



addons/models/3000-Cloud/3060-gcp_typedefs.json
Lines 107 (patched)
<https://reviews.apache.org/r/73257/#comment311932>

    review all "string" type attributes to enable isIndexable -> true


- Sarath Subramanian


On March 30, 2021, 5:09 p.m., Sidharth Mishra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73257/
> -----------------------------------------------------------
> 
> (Updated March 30, 2021, 5:09 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4226
>     https://issues.apache.org/jira/browse/ATLAS-4226
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Add model types for Google cloud storage
> 
> 
> Diffs
> -----
> 
>   addons/models/3000-Cloud/3060-gcp_typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73257/diff/3/
> 
> 
> Testing
> -------
> 
> Manually tested if the patch application is successful and entity creation is 
> working.
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Reply via email to