> On March 30, 2021, 10:45 p.m., Madhan Neethiraj wrote:
> > addons/models/3000-Cloud/3060-gcp_typedefs.json
> > Lines 129 (patched)
> > <https://reviews.apache.org/r/73257/diff/2/?file=2248306#file2248306line129>
> >
> >     Please review if use of an enum is feasible here.

This mainly contains the effective time, expiration date , locked or not etc. 
For more details please check - 
https://cloud.google.com/storage/docs/bucket-lock?authuser=3


- Sidharth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73257/#review222741
-----------------------------------------------------------


On March 31, 2021, 12:09 a.m., Sidharth Mishra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73257/
> -----------------------------------------------------------
> 
> (Updated March 31, 2021, 12:09 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4226
>     https://issues.apache.org/jira/browse/ATLAS-4226
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Add model types for Google cloud storage
> 
> 
> Diffs
> -----
> 
>   addons/models/3000-Cloud/3060-gcp_typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73257/diff/3/
> 
> 
> Testing
> -------
> 
> Manually tested if the patch application is successful and entity creation is 
> working.
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Reply via email to